Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-17360: Add topics for mapper scheduled cleanup and update cleanup Avro records #1265

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

JamesHR3
Copy link
Collaborator

Problem statement

As part of ongoing performance work, there is a requirement to move the storage of flow mapper states to a shared state store. This will break the current implementation of mapper state cleanup. Flow mapper states are currently cleaned up using a scheduler implemented in each flow mapper, which relies on states being partitioned across the set of mapper instances. This will no longer be happening.

This problem can be addressed using the new task scheduler implemented in the DB worker, but doing so will require a few new topics for the mapper to listen to.

Solution

Add two new topics. The first is the topic that scheduled tasks for the flow mapper will be written to. The second is a dedicated cleanup event topic that will be written to as part of processing the scheduled event.

In addition, the ExecuteCleanup event has been modified to take a list of IDs as a field. This will allow the processor of the scheduled task to batch up the cleanup requests being sent to the mapper workers.

@JamesHR3 JamesHR3 requested review from jujoramos, conalsmith-r3 and a team September 26, 2023 18:51
@JamesHR3 JamesHR3 requested a review from a team as a code owner September 26, 2023 18:51
@JamesHR3 JamesHR3 self-assigned this Sep 26, 2023
Copy link
Contributor

@jujoramos jujoramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will approve once tests have been fixed 👍 .

@corda-jenkins-ci02
Copy link
Contributor

Jenkins build for PR 1265 build 5

Build Successful:
Jar artifact version produced by this PR: 5.1.0.25-alpha-1695819131422

Copy link
Contributor

@jujoramos jujoramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesHR3 JamesHR3 merged commit 4c8fcdf into release/os/5.1 Sep 28, 2023
2 checks passed
@JamesHR3 JamesHR3 deleted the jamesh/core-17360-mapper-cleanup-topic branch September 28, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants